Fix known issues for cache - #1260
Merged
Merged
Conversation
Phantsure
force-pushed
the
phantsure/cache-testing
branch
from
December 9, 2022 11:10
9a0cb81 to
0c23c38
Compare
Phantsure
changed the title
Phantsure
changed the title
Phantsure
marked this pull request as ready for review
December 9, 2022 11:24
and address review comments
Comment on lines
+157
to
+159
| if (BSD_TAR_ZSTD) { | ||
| return args | ||
| } |
There was a problem hiding this comment.
Instead of this, just return directly from L152 and L154
Contributor
Author
There was a problem hiding this comment.
It returns only in case of bsd tar. Else it will go down
bishal-pdMSFT
approved these changes
Dec 12, 2022
Co-authored-by: Bishal Prasad <bishal-pdmsft@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix known issue with gzip fallback and bsd tar + zstd combination.
exec.execdoesn't support&&so passed commands throughcmdfor that case only as suggested here